Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rcl_clock_t jump callbacks #543

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Use rcl_clock_t jump callbacks #543

merged 2 commits into from
Aug 28, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 27, 2018

Relieves rclcpp::TimeSource responsibility of calling jump callbacks.

(Changed branch name to disconnect PRs)

Requires ros2/rcl#284

@sloretz sloretz added the in review Waiting for review (Kanban column) label Aug 27, 2018
@sloretz sloretz self-assigned this Aug 27, 2018
rclcpp::JumpHandler * handler = static_cast<rclcpp::JumpHandler *>(user_data);
if (before_jump && handler->pre_callback) {
handler->pre_callback();
} else if (handler->post_callback) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditions in the if and else if look weird. If before_jump is true but the handler only has a post callback it is being called here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test and fixed in af09c59

Relieves rclcpp::TimeSource responsibility of calling jump callbacks.
@sloretz
Copy link
Contributor Author

sloretz commented Aug 28, 2018

CI testing just rclcpp since I don't expect these changes to impact anything downstream.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz merged commit a55e320 into master Aug 28, 2018
@sloretz sloretz deleted the rclcpp_time_jump_callbacks branch August 28, 2018 17:12
@sloretz sloretz removed the in review Waiting for review (Kanban column) label Aug 28, 2018
@sloretz
Copy link
Contributor Author

sloretz commented Aug 28, 2018

CI testing just rclcpp since I don't expect these changes to impact anything downstream.

I made a mistake here. tf2_ros uses time jump callbacks and is now broken. Will fix shortly

DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* Implement streaming compression/decompression

Distro A, OPSEC #4584

Signed-off-by: P. J. Reed <preed@swri.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants